[PATCH] D150768: [SVE ACLE] Canonicalise SVE merging intrinsics

mgabka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 04:17:02 PDT 2023


mgabka added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1688
+    auto Replacement = instCombineSVEVectorBinOp(IC, II);
+    if (Replacement == std::nullopt)
+      return instCombineSVEVectorFuseMulAddSub<Intrinsic::aarch64_sve_fmul_u,
----------------
Hi Jolanta,
I think that code like:

if (auto Replacement = instCombineSVEVectorBinOp(IC, II))
    return Replacement;

return instCombineSVEVectorFuseMulAddSub

would be more readable here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150768/new/

https://reviews.llvm.org/D150768



More information about the llvm-commits mailing list