[PATCH] D150606: [RegisterCoalescer] Remove DbgMergedVRegNums (NFC)
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 18 16:03:21 PDT 2023
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3eccb40fa983: [RegisterCoalescer] Remove DbgMergedVRegNums (NFC) (authored by aheejin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150606/new/
https://reviews.llvm.org/D150606
Files:
llvm/lib/CodeGen/RegisterCoalescer.cpp
Index: llvm/lib/CodeGen/RegisterCoalescer.cpp
===================================================================
--- llvm/lib/CodeGen/RegisterCoalescer.cpp
+++ llvm/lib/CodeGen/RegisterCoalescer.cpp
@@ -153,12 +153,6 @@
using DbgValueLoc = std::pair<SlotIndex, MachineInstr*>;
DenseMap<Register, std::vector<DbgValueLoc>> DbgVRegToValues;
- /// VRegs may be repeatedly coalesced, and have many DBG_VALUEs attached.
- /// To avoid repeatedly merging sets of DbgValueLocs, instead record
- /// which vregs have been coalesced, and where to. This map is from
- /// vreg => {set of vregs merged in}.
- DenseMap<Register, SmallVector<Register, 4>> DbgMergedVRegNums;
-
/// A LaneMask to remember on which subregister live ranges we need to call
/// shrinkToUses() later.
LaneBitmask ShrinkMask;
@@ -3768,18 +3762,9 @@
checkMergingChangesDbgValuesImpl(Reg, LHS, RHS, RHSVals);
};
- // Scan for potentially unsound DBG_VALUEs: examine first the register number
- // Reg, and then any other vregs that may have been merged into it.
- auto PerformScan = [this](Register Reg, std::function<void(Register)> Func) {
- Func(Reg);
- if (DbgMergedVRegNums.count(Reg))
- for (Register X : DbgMergedVRegNums[Reg])
- Func(X);
- };
-
// Scan for unsound updates of both the source and destination register.
- PerformScan(CP.getSrcReg(), ScanForSrcReg);
- PerformScan(CP.getDstReg(), ScanForDstReg);
+ ScanForSrcReg(CP.getSrcReg());
+ ScanForDstReg(CP.getDstReg());
}
void RegisterCoalescer::checkMergingChangesDbgValuesImpl(Register Reg,
@@ -4160,7 +4145,6 @@
MF->verify(this, "Before register coalescing");
DbgVRegToValues.clear();
- DbgMergedVRegNums.clear();
buildVRegToDbgValueMap(fn);
RegClassInfo.runOnMachineFunction(fn);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150606.523594.patch
Type: text/x-patch
Size: 1816 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230518/d4c715cb/attachment.bin>
More information about the llvm-commits
mailing list