[PATCH] D150607: [DebugInfo][NFCI] Refactor DWARFAbbreviationDeclaration::extract

[Alex Langford via Phabricator via llvm-commits]

bulbazord created this revision.
bulbazord added reviewers: aprantl, dblaikie, probinson, jhenderson, JDevlieghere.
Herald added a subscriber: hiraditya.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The motivation behind this refactor is to be able to use
DWARFAbbreviationDeclaration from LLDB. LLDB has its own implementation
of DWARFAbbreviationDeclaration that is very similar to LLVM's but it
has different semantics around error handling.

This patch modifies llvm::DWARFAbbreviationDeclaration::extract to
return an `llvm::Expected<ExtractState>` to differentiate between "I am
done extracting" and "An error has occured", something which the current
return type (bool) does not accurately capture.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150607

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFAbbreviationDeclaration.h
  llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150607.522316.patch
Type: text/x-patch
Size: 7987 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230515/1657045a/attachment.bin>