[PATCH] D149711: [PowerPC] Remove asserts from the disassembler.
Amy Kwan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 18 07:32:28 PDT 2023
amyk added a comment.
Could we also update the description of the patch to specify what `My previous patch` means (as in, which patch)?
================
Comment at: llvm/test/MC/Disassembler/PowerPC/ppc64-encoding-dfp.txt:27
+
+# This is actually the encoding for an invalid instruction.
+# However, we check it here because the disassembler shouldn't check if an
----------------
Might be a silly question, but I have a clarification question.
Is the goal here, we want the disassembler to still continue decoding an instruction (even if it is invalid/illegal), but cannot have it assert? Does anything special need to happen after we have decoded an illegal instruction?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149711/new/
https://reviews.llvm.org/D149711
More information about the llvm-commits
mailing list