[PATCH] D150674: [RISCV] Set GenCrashDialog=false for various report_fatal_error calls in lib/Target/RISCV

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 03:42:25 PDT 2023

asb added a comment.

In D150674#4346919 <https://reviews.llvm.org/D150674#4346919>, @arsenm wrote:

> This should be the universal default. report_fatal_error should not emit crash dialogs

Thanks for taking a look. Just for the sake of clarity, is this a general comment or a request to invert the default behaviour of report_fatal_error rather than landing this patch? If the latter - I'd say I'm happy to help improve things here and even post an RFC on the issue, but I'm also well aware it's likely to take a long time to land (not least as it will re-raise the issue, as this patch has, of inadequacies in LLVM's error handling infrastructure). So my preference would be to land this incremental improvement and separate that from work to flip the default or make other broader changes.



More information about the llvm-commits mailing list