[PATCH] D150674: [RISCV] Set GenCrashDialog=false for various report_fatal_error calls in lib/Target/RISCV

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D150674#4346704 <https://reviews.llvm.org/D150674#4346704>, @MaskRay wrote:

> `report_fatal_error` is a lazy error reporting mechanism that should be avoided. Adding `false` (`exit(1)` instead of `abort()`) just papers over the issue...

It's appropriate for certain things. This isn't for issues end users should encounter. There are plenty of situations that need to be treated as not-an-assert and exit, such as situations only reachable through handwritten MIR


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150674/new/

https://reviews.llvm.org/D150674