[PATCH] D149699: [InstCombine] Improve bswap optimization

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D149699#4347068 <https://reviews.llvm.org/D149699#4347068>, @goldstein.w.n wrote:

> In D149699#4346601 <https://reviews.llvm.org/D149699#4346601>, @austin880625 wrote:
>
>> Thanks for helping out! Here's the proposed commit message
>>
>>   Recommit: [InstCombine] Improve bswap optimization(2nd try)
>>   
>>   Check the operator is BinaryOperator before cast so that we won't match ConstExpr
>
> Does:
>
>   Recommit "[InstCombine] Improve bswap optimization" (2nd try)
>   
>   Issue was assertion failure due to an unchecked `cast`. Fix is to check the operator is
>   `BinaryOperator` before cast so that we won't match `ConstExpr`
>
> Sound okay? Just to reference what the original issue was.

BTW: Austin Chang <austin880625 at gmail.com>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149699/new/

https://reviews.llvm.org/D149699