[PATCH] D149699: [InstCombine] Improve bswap optimization

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D149699#4346601 <https://reviews.llvm.org/D149699#4346601>, @austin880625 wrote:

> Thanks for helping out! Here's the proposed commit message
>
>   Recommit: [InstCombine] Improve bswap optimization(2nd try)
>   
>   Check the operator is BinaryOperator before cast so that we won't match ConstExpr

Does:

  Recommit "[InstCombine] Improve bswap optimization" (2nd try)
  
  Issue was assertion failure due to an unchecked `cast`. Fix is to check the operator is
  `BinaryOperator` before cast so that we won't match `ConstExpr`

Sound okay? Just to reference what the original issue was.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149699/new/

https://reviews.llvm.org/D149699