[PATCH] D150607: [DebugInfo][NFCI] Refactor DWARFAbbreviationDeclaration::extract

[Alex Langford via Phabricator via llvm-commits]

bulbazord added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:50
+    return make_error<llvm::object::GenericBinaryError>(
+        "Abbreviation declaration requires a non-null Tag!");
   }
----------------
jhenderson wrote:
> (ignore this suggestion if this isn't going to end up as a user-facing error)
> 
> There are guidelines on error and warning formatting (see https://llvm.org/docs/CodingStandards.html#error-and-warning-messages), so we should conform to those in new code, unless there's a strong reason not to.
Thanks for pointing that out. They will be user-facing from LLDB (and possibly from LLVM tools in the future), so I'll update this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150607/new/

https://reviews.llvm.org/D150607