[PATCH] D150607: [DebugInfo][NFCI] Refactor DWARFAbbreviationDeclaration::extract

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:50
+    return make_error<llvm::object::GenericBinaryError>(
+        "Abbreviation declaration requires a non-null Tag!");
   }
----------------
(ignore this suggestion if this isn't going to end up as a user-facing error)

There are guidelines on error and warning formatting (see https://llvm.org/docs/CodingStandards.html#error-and-warning-messages), so we should conform to those in new code, unless there's a strong reason not to.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:77
+      return make_error<llvm::object::GenericBinaryError>(
+          "Malformed abbreviation declaration attribute!");
+    }
----------------
Same as above.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:128-129
+  return make_error<llvm::object::GenericBinaryError>(
+      "Abbreviation declaration attribute list was not terminated with a null "
+      "entry!");
 }
----------------
Same as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150607/new/

https://reviews.llvm.org/D150607