[PATCH] D149931: [RISCV] Rework how implied SP operands work in the disassembler. NFC

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 08:20:58 PDT 2023


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:442
 
+// Add implied SP operand for instructions *SP compressed instructions. The SP
+// operand isn't explicitly encoded in the instruction.
----------------
I know you just copied this from the previous function, but perhaps change to "Add implied SP operand for C.*SP compressed instructions. [...]"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149931/new/

https://reviews.llvm.org/D149931



More information about the llvm-commits mailing list