[PATCH] D150633: [X86]check that Uses, Defs are same for entries in memory folding table

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:120
+      if (ListOfUsesReg != ListOfUsesMem || ListOfDefsReg != ListOfDefsMem)
+        llvm::report_fatal_error(
+            "Uses/Defs couldn't be changed after folding " +
----------------
pengfei wrote:
> skan wrote:
> > drop namespace llvm?
> Given the code for Debug build only, why don't use assert directly?
How to include `RegInstRec.getName()` and `MemInstRec.getName()` in assertion message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150633/new/

https://reviews.llvm.org/D150633