[PATCH] D150633: [X86]check that Uses, Defs are same for entries in memory folding table

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 07:36:49 PDT 2023


pengfei added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:120
+      if (ListOfUsesReg != ListOfUsesMem || ListOfDefsReg != ListOfDefsMem)
+        llvm::report_fatal_error(
+            "Uses/Defs couldn't be changed after folding " +
----------------
skan wrote:
> drop namespace llvm?
Given the code for Debug build only, why don't use assert directly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150633/new/

https://reviews.llvm.org/D150633



More information about the llvm-commits mailing list