[PATCH] D150438: [LLVM][Uniformity] Improve detection of uniform registers

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 07:25:32 PDT 2023


Petar.Avramovic added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:423
   let hasSideEffects = 1;
+  let IsNeverUniform = 1;
 }
----------------
ruiling wrote:
> I think ``SI_IF` and `SI_ELSE` also need this flag being set, but it can be done in a separate change with proper tests.
I think the same. Marking SI_IF and SI_ELSE as never uniform fixed test failures I was seeing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150438/new/

https://reviews.llvm.org/D150438



More information about the llvm-commits mailing list