[PATCH] D150445: [LLD][ELF] Add missing program header parsing to OVERLAY
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 15 02:22:22 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe16af8a28169: [LLD][ELF] Add missing program header parsing to OVERLAY (authored by psmith).
Herald added a project: LLVM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150445/new/
https://reviews.llvm.org/D150445
Files:
lld/ELF/ScriptParser.cpp
lld/test/ELF/linkerscript/overlay-phdr.test
Index: lld/test/ELF/linkerscript/overlay-phdr.test
===================================================================
--- /dev/null
+++ lld/test/ELF/linkerscript/overlay-phdr.test
@@ -0,0 +1,33 @@
+# REQUIRES: x86
+# RUN: echo 'nop; .section .small, "a"; .long 0; .section .big, "a"; .quad 1;' \
+# RUN: | llvm-mc -filetype=obj -triple=x86_64-unknown-linux - -o %t.o
+# RUN: ld.lld %t.o --script %s -o %t
+
+PHDRS {
+ PH1 PT_LOAD;
+ PH2 PT_LOAD;
+}
+
+SECTIONS {
+ OVERLAY 0x1000 : AT ( 0x4000 ) {
+ .out.big { *(.big) } : PH1
+ .out.small { *(.small) } : PH2
+ }
+}
+
+## A variant of overlay.test with explicit program header assingment.
+## Check that we generate two program headers consistent with the overlay
+
+# RUN: llvm-readelf --sections -l %t | FileCheck %s
+
+# CHECK: Section Headers:
+# CHECK: Name Type Address Off Size
+# CHECK: .out.big PROGBITS 0000000000001000 001000 000008
+# CHECK: .out.small PROGBITS 0000000000001000 002000 000004
+# CHECK: .text PROGBITS 0000000000001008 002008 000001
+
+
+# CHECK: Program Headers:
+# CHECK: Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align
+# CHECK-NEXT: LOAD 0x001000 0x0000000000001000 0x0000000000004000 0x000008 0x000008 R 0x1000
+# CHECK-NEXT: LOAD 0x002000 0x0000000000001000 0x0000000000004008 0x000009 0x000009 R E 0x1000
Index: lld/ELF/ScriptParser.cpp
===================================================================
--- lld/ELF/ScriptParser.cpp
+++ lld/ELF/ScriptParser.cpp
@@ -898,6 +898,7 @@
osd->osec.commands.push_back(
readInputSectionRules(next(), withFlags, withoutFlags));
}
+ osd->osec.phdrs = readOutputSectionPhdrs();
return osd;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150445.522095.patch
Type: text/x-patch
Size: 1728 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230515/a9765096/attachment.bin>
More information about the llvm-commits
mailing list