[PATCH] D150107: [X86] Remove patterns for shift/rotate with immediate 1 and optimize during MC lowering

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86EncodingOptimization.cpp:151
+    return false;
+    FROM_TO(ROL8ri, ROR8r1, 7)
+    FROM_TO(ROR8ri, ROL8r1, 7)
----------------
Are the flags the same? I don't think we ever use the flags from rotate, but since we're treating this like almost an assembler optimization we should probably know if we'll break any future flag usages.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150107/new/

https://reviews.llvm.org/D150107