[PATCH] D150121: [SLP][NFC]Add missing finalize params in the CostEstimator, NFC.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 09:04:17 PDT 2023


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7123
   void add(const TreeEntry *E1, ArrayRef<int> Mask) {
     CommonMask.assign(Mask.begin(), Mask.end());
     InVectors.assign(1, E1);
----------------
RKSimon wrote:
> maybe add the assertion in these other add() methods as well (in a separate commit).
Most probably the next patch will make these functions more smart.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150121/new/

https://reviews.llvm.org/D150121



More information about the llvm-commits mailing list