[PATCH] D150121: [SLP][NFC]Add missing finalize params in the CostEstimator, NFC.
    Simon Pilgrim via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon May 15 09:02:19 PDT 2023
    
    
  
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with one minor
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7123
   void add(const TreeEntry *E1, ArrayRef<int> Mask) {
     CommonMask.assign(Mask.begin(), Mask.end());
     InVectors.assign(1, E1);
----------------
maybe add the assertion in these other add() methods as well (in a separate commit).
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150121/new/
https://reviews.llvm.org/D150121
    
    
More information about the llvm-commits
mailing list