[PATCH] D148692: Fix uninitialized class members

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 09:41:00 PDT 2023


dblaikie added a comment.

In D148692#4282704 <https://reviews.llvm.org/D148692#4282704>, @LuoYuanke wrote:

> In D148692#4282643 <https://reviews.llvm.org/D148692#4282643>, @mehdi_amini wrote:
>
>> The description is missing context, are these fixing bugs? How were these issues found?
>
> I think these are to fix the issues that reported by Coverity/Klocwork tool.

For the record - these sort of changes may not be desirable.

Adding initializers to variables that don't need it (because through some dynamic path they are initialized before they're used) may hinder tools like msan from finding real bugs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148692/new/

https://reviews.llvm.org/D148692



More information about the llvm-commits mailing list