[PATCH] D150311: [MISched] Use StartAtCycle in trace dumps.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 07:31:08 PDT 2023
RKSimon added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:165
+ "misched-sort-respources-in-trace", cl::Hidden, cl::init(false),
+ cl::desc("Sort the resources printed in the dump trace"));
#endif
----------------
Add test coverage for this switch?
================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1024
+ assert(PI->StartAtCycle < PI->Cycles && "Invalid resource usage");
+ for (unsigned i = 0; i < (PI->Cycles - PI->StartAtCycle); ++i, ++C)
dbgs() << llvm::left_justify("| x", ColWidth);
----------------
(style)
```
for (unsigned I = 0, E = PI->Cycles - PI->StartAtCycle; I != E; ++i, ++C)
```
================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1094
+ LHS->Cycles < RHS->Cycles);
+ });
+ for (TargetSchedModel::ProcResIter PI : ResourcesIt) {
----------------
use llvm::sort
================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1104
+ assert(PI->StartAtCycle < PI->Cycles && "Invalid resource usage");
+ for (unsigned i = 0; i < (PI->Cycles - PI->StartAtCycle); ++i, --C)
dbgs() << llvm::left_justify("| x", ColWidth);
----------------
(style)
```
for (unsigned I = 0, E = PI->Cycles - PI->StartAtCycle; I != E; ++I, --C)
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150311/new/
https://reviews.llvm.org/D150311
More information about the llvm-commits
mailing list