[PATCH] D149659: [AArch64][NFC] Refactor the tail-folding option

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h:541
+///   TFAll:         All
+enum TailFoldingOpts : uint8_t {
+  TFDisabled = 0x00,
----------------
sdesmalen wrote:
> nit: Can you put this in a namespace, e.g.
> 
>   namespace TailFoldingOpts {
>     enum TailFoldingOptsImpl : uint8_t {
>       Disabled = 0x00;
>       Simple = 0x01;
>       ...
>     };
>   };
> 
> That makes it a bit easier to use these, e.g.
> 
>   TailFoldingOpts::Disabled
>   TailFoldingOpts::Simple
>   ...
The modern way to do this is via an enum class?, i.e.
```
  enum class TailFoldingOpt : uint8_t {
    Disabled = 0x00;
    Simple = 0x01;
    ...
  };
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149659/new/

https://reviews.llvm.org/D149659