[PATCH] D149659: [AArch64][NFC] Refactor the tail-folding option

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:131
   unsigned VScaleForTuning = 2;
+  uint8_t DefaultSVETFOpts = TFDisabled;
 
----------------
There are several of these `uint8_t` flying round, which will make it awkward to change later.  Perhaps worth using a typedef?


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:77
+  TailFoldingOption()
+      : InitialBits(0), EnableBits(0), DisableBits(0), NeedsDefault(false) {}
 
----------------
I think the modern way to do this is inline with the variable definitions, i.e
```
uint8_t InitialBits = 0;
...
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149659/new/

https://reviews.llvm.org/D149659