[PATCH] D149768: [ArgumentPromotion] Bail if any callers are minsize and more instructions are added than removed

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

Okay, the new revision is better, but it's still a 204 KiB overall size increase for the Facebook Android app, which is considered significant. The previous iteration was a 244 KiB size increase, for reference.

I'm gonna try a `-print-after-all -print-changed` IR dump from the LTO run to see if I can spot any obvious causes. ArgPromo is kinda uniquely tricky to reason about that way because of the changes being scattered across the function itself and its callees though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149768/new/

https://reviews.llvm.org/D149768