[PATCH] D149768: [ArgumentPromotion] Bail if any callers are minsize and more instructions are added than removed

Tue May 9 14:58:44 PDT 2023

smeenai added a comment.

In D149768#4330790 <https://reviews.llvm.org/D149768#4330790>, @aeubanks wrote:

> In D149768#4330784 <https://reviews.llvm.org/D149768#4330784>, @smeenai wrote:
>
>> Thanks for the update! I'm working on testing the size change with the new revision, but our internal infra for that is a little broken right now, so it might take a bit. I'm also still struggling with llvm-reduce's tendency to introduce `unreachable` in reachable places and use uninitialized memory, unfortunately.
>
> No rush :)
>
> I'm not sure how you're trying using llvm-reduce, it's not meant for any meaningful semantics-preserving transformations.

Ah, that'd explain a lot :) I was trying to use it with an interestingness test of "is the output from a toolchain with this change meaningfully larger than the output from a toolchain without", but I guess it's more intended for crash tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149768/new/

https://reviews.llvm.org/D149768