[PATCH] D147750: [LAA/LV] Simplify stride speculation logic [nfc]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 08:22:36 PDT 2023


reames added a comment.

In D147750#4328090 <https://reviews.llvm.org/D147750#4328090>, @Ayal wrote:

> LGTM, worth `using ValueToSCEVMap = DenseMap<const Value *, const SCEV *>` ?

I looked at this, but I don't think it helps clarify.  We have an existing ValueToSCEVMapTy which differs in constness of the key.  We've also got both ValueToValueMap and ValueToValueMapTy (they're different).  As a cleanup after this, I'm going to go take a look and see if I can clean these up slightly, but I'm not expecting huge clarity wins in this code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147750/new/

https://reviews.llvm.org/D147750



More information about the llvm-commits mailing list