[PATCH] D147750: [LAA/LV] Simplify stride speculation logic [nfc]

Mon May 8 16:49:19 PDT 2023

Ayal added a comment.

LGTM, worth `using ValueToSCEVMap = DenseMap<const Value *, const SCEV *>` ?

================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:703
   /// If an access has a symbolic strides, this maps the pointer value to
   /// the stride symbol.
+  DenseMap<Value *, const SCEV *> SymbolicStrides;
----------------
Documentation here and above still seems fine, right?

================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:722
 const SCEV *replaceSymbolicStrideSCEV(PredicatedScalarEvolution &PSE,
-                                      const ValueToValueMap &PtrToStride,
+                                      const DenseMap<Value *, const SCEV *> &PtrToStride,
                                       Value *Ptr);
----------------
80 columns?

================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2697
+  // Note: getStrideFromPointer is a *profitability* heuristic.  We
+  // could broden the scope of values returned here - to anything
+  // which happens to be loop invariant and contributes to the
----------------

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147750/new/

https://reviews.llvm.org/D147750