[PATCH] D149996: [test] [ExecutionEngine] Skip the ExecutionEngine tests on mingw targets

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

In D149996#4331558 <https://reviews.llvm.org/D149996#4331558>, @mstorsjo wrote:

> In D149996#4331020 <https://reviews.llvm.org/D149996#4331020>, @lhames wrote:
>
>> I think the failure to honor `-mtriple` should be treated as a bug here -- I'll add a patch to fix this.
>
> Maybe, but do note that there's a subtle existing tweak for MCJIT, it uses triples like `x86_64-pc-windows-msvc-elf`, set up here: https://github.com/llvm/llvm-project/blob/main/llvm/test/lit.cfg.py#L96-L102 If we start honoring that when not using `-jit-kind=mcjit`, the tests that run with Orc end up doing and testing a totally different thing, I'm afraid...

Thanks for pointing this out. I'll sink that argument down into the MCJIT tests.

For the new tests: Do Cygwin / MinGW use ELF or COFF by default? COFF support has improved a lot, so if that's the default we should try to just use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149996/new/

https://reviews.llvm.org/D149996