[PATCH] D150286: [RISCV] Fold (select setcc, setcc, setcc) into and/or instructions

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 12:07:26 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5354
+
+static SetCCCompareResult compareSetCC(SDValue LHS, SDValue RHS,
+                                       ISD::CondCode CC, SDValue Val) {
----------------
Can we return std::optional<bool> similar to `isImpliedCondition` from lib/Analysis/ValueTracking. I think this is very similar to that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150286/new/

https://reviews.llvm.org/D150286



More information about the llvm-commits mailing list