[PATCH] D146749: [CodeGen] Fix nomerge attribute not working in tail calls.

Wed May 10 11:11:44 PDT 2023

jrtc27 added a comment.

In D146749#4332699 <https://reviews.llvm.org/D146749#4332699>, @rnk wrote:

> This looks good to me.
>
> I thought perhaps it would be shorter and simpler to have addNoMergeInfo take and return the SDValue which is being marked to avoid the need for new SDValue variables, but I don't think that's essential.
>
> @jrtc27 , are your concerns addressed?
>
> Regarding globalisel, @zequanwu , can you file an issue for implementing nomerge support in globalisel? It's probably easiest to construct an example with the AArch64 backend.

Yes, the tests are much cleaner now, both in content and in reviewability of the diff, thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146749/new/

https://reviews.llvm.org/D146749