[PATCH] D146749: [CodeGen] Fix nomerge attribute not working in tail calls.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 10 11:08:08 PDT 2023
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
This looks good to me.
I thought perhaps it would be shorter and simpler to have addNoMergeInfo take and return the SDValue which is being marked to avoid the need for new SDValue variables, but I don't think that's essential.
@jrtc27 , are your concerns addressed?
Regarding globalisel, @zequanwu , can you file an issue for implementing nomerge support in globalisel? It's probably easiest to construct an example with the AArch64 backend.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146749/new/
https://reviews.llvm.org/D146749
More information about the llvm-commits
mailing list