[PATCH] D148584: [FS-AFDO] Load pseudo probe profile on MIR
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 10 10:48:20 PDT 2023
hoy added inline comments.
================
Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:111
+ // Ignore callsite probes since they do not have FS discriminators.
+ return std::nullopt;
+}
----------------
wenlei wrote:
> So we don't do FS profile loading for call probes because discriminator on call probe is already occupied for probe id, hence call probe effectively doesn't have FS discriminator?
Exactly. We are relying on block probes only to get a FS count for basic blocks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148584/new/
https://reviews.llvm.org/D148584
More information about the llvm-commits
mailing list