[PATCH] D148584: [FS-AFDO] Load pseudo probe profile on MIR

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 10:45:28 PDT 2023


wenlei added a comment.

lgtm, thanks.



================
Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:111
+  // Ignore callsite probes since they do not have FS discriminators.
+  return std::nullopt;
+}
----------------
So we don't do FS profile loading for call probes because discriminator on call probe is already occupied for probe id, hence call probe effectively doesn't have FS discriminator? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148584/new/

https://reviews.llvm.org/D148584



More information about the llvm-commits mailing list