[PATCH] D148921: [llvm-exegesis] Use MCJIT only for execution

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 01:01:41 PDT 2023


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-exegesis/lib/Assembler.cpp:345
+  auto SectionOrErr = Functions.front().getSection();
+  if (!SectionOrErr || *SectionOrErr == Obj->section_end())
+    return make_error<Failure>("Section not found");
----------------
courbet wrote:
> [nit] Propagate the error ?
ping


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148921/new/

https://reviews.llvm.org/D148921



More information about the llvm-commits mailing list