[PATCH] D150127: Undo include order work-around in Regex.cpp
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 9 00:20:06 PDT 2023
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9d7eb6008716: Undo include order work-around in Regex.cpp (authored by hans).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150127/new/
https://reviews.llvm.org/D150127
Files:
llvm/lib/Support/Regex.cpp
Index: llvm/lib/Support/Regex.cpp
===================================================================
--- llvm/lib/Support/Regex.cpp
+++ llvm/lib/Support/Regex.cpp
@@ -14,14 +14,11 @@
#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/Twine.h"
+#include "regex_impl.h"
+
#include <cassert>
#include <string>
-// Important this comes last because it defines "_REGEX_H_". At least on
-// Darwin, if included before any header that (transitively) includes
-// xlocale.h, this will cause trouble, because of missing regex-related types.
-#include "regex_impl.h"
-
using namespace llvm;
Regex::Regex() : preg(nullptr), error(REG_BADPAT) {}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150127.520607.patch
Type: text/x-patch
Size: 680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230509/38e91cb7/attachment.bin>
More information about the llvm-commits
mailing list