[PATCH] D150127: Undo include order work-around in Regex.cpp

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 15:19:53 PDT 2023


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

In D150117#4326737 <https://reviews.llvm.org/D150117#4326737>, @thakis wrote:

> JDevlieghere, do you remember why you went with that other approach?

I don't remember. My best guess is that  was probably trying to avoid modifying `regex_impl.h` because it is/was a verbatim copy of the BSD regex implementation. This is definitely better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150127/new/

https://reviews.llvm.org/D150127



More information about the llvm-commits mailing list