[PATCH] D150068: [X86][AsmParser] Refactor code in AsmParser

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 07:39:35 PDT 2023


skan created this revision.
Herald added subscribers: pengfei, dmgreen, hiraditya.
Herald added a project: All.
skan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

1. Share code `optimizeInstFromVEX3ToVEX2` with MCInstLower
2. Move the code of optimization for shift/rotate to a separate file
3. Remove the comments like "asm matcher is currently incapable of matching a fixed immediate". Different targets have different literal constants for immediate, and each literal is treated as individual token. Since "gen-asm-matcher" is target-independent backend, I believe tblgen will not and should not support this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150068

Files:
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/lib/Target/X86/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/X86/MCTargetDesc/X86InstrOptimization.cpp
  llvm/lib/Target/X86/MCTargetDesc/X86InstrOptimization.h
  llvm/lib/Target/X86/X86InstrAsmAlias.td
  llvm/lib/Target/X86/X86MCInstLower.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150068.520188.patch
Type: text/x-patch
Size: 21048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230507/322d2eec/attachment.bin>


More information about the llvm-commits mailing list