[PATCH] D149833: [X86][AsmParser] Omit predicate In64BitMode for instructions w/ GP64 operand in X86InstrArithmetic.td, NFCI

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:4193
+    bool HasImplicitIn64BitMode =
+        (TSFlags & X86II::REX_W) && !(TSFlags & X86II::EncodingMask);
+    if (!is64BitMode() && HasImplicitIn64BitMode)
----------------
craig.topper wrote:
> The issue also appears on the VEX and EVEX encoded memory form of vextractps.
Should `!(TSFlags & X86II::EncodingMask)` be used to prevent for VEX and EVEX? Anyway, I agree it's a bit big hammer for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149833/new/

https://reviews.llvm.org/D149833