[PATCH] D148868: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:1061
+  if (IsMD5) {
+    auto Size = readNumber<size_t>();
+    if (std::error_code EC = Size.getError())
----------------
huangjd wrote:
> davidxl wrote:
> > add assert (!FixedLengthMD5);
> This is not needed because the previous if(FixedLengthMD5) always returns, so this assert is always true. 
> This is not needed because the previous if(FixedLengthMD5) always returns, so this assert is always true. 

right it is redundant with the current control flow. It is probably still worth adding one to prevent problems in the future if the code structure changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148868/new/

https://reviews.llvm.org/D148868