[PATCH] D148868: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring

[William Junda Huang via Phabricator via llvm-commits]

huangjd marked 3 inline comments as done.
huangjd added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:1038
   if (FixedLengthMD5) {
+    auto Size = readNumber<size_t>();
+    if (std::error_code EC = Size.getError())
----------------
davidxl wrote:
> Add assert(IsMD5).
Added


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:1061
+  if (IsMD5) {
+    auto Size = readNumber<size_t>();
+    if (std::error_code EC = Size.getError())
----------------
davidxl wrote:
> add assert (!FixedLengthMD5);
This is not needed because the previous if(FixedLengthMD5) always returns, so this assert is always true. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148868/new/

https://reviews.llvm.org/D148868