[PATCH] D149833: [X86] Omit predicate In64BitMode for instructions w/ GP64 operand in X86InstrArithmetic.td, NFCI

Thu May 4 08:11:18 PDT 2023

pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

In D149833#4318345 <https://reviews.llvm.org/D149833#4318345>, @skan wrote:

> In D149833#4318229 <https://reviews.llvm.org/D149833#4318229>, @pengfei wrote:
>
>> I think we cannot remove it for memory only variants. The `addr` is legal on both 32-bits and 64-bits.
>
> But looking at the definition of `loadi64`
>
>   def loadi64  : PatFrag<(ops node:$ptr), (i64 (load node:$ptr))>;
>
> , which is the operator of `addr`, it seems loadi64 is only matched in 64-bit mode due to i64.

That makes sense to me. Although I still have concerns about that, I cannot find a evidence for now. So LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149833/new/

https://reviews.llvm.org/D149833