[PATCH] D149833: [X86] Omit predicate In64BitMode for instructions w/ GP64 operand in X86InstrArithmetic.td, NFCI

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 03:51:10 PDT 2023


skan added a comment.

In D149833#4318229 <https://reviews.llvm.org/D149833#4318229>, @pengfei wrote:

> I think we cannot remove it for memory only variants. The `addr` is legal on both 32-bits and 64-bits.

But looking at the definition of `loadi64`

  def loadi64  : PatFrag<(ops node:$ptr), (i64 (load node:$ptr))>;

, which is the operator of `addr`. It uses `i64`, which is only legal in 64-bit mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149833/new/

https://reviews.llvm.org/D149833



More information about the llvm-commits mailing list