[PATCH] D149712: [SLP][NFC] Cleanup: Add while loop around for loop instead of modifying iterators.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added a comment.

In D149712#4316416 <https://reviews.llvm.org/D149712#4316416>, @vporpo wrote:

>> I assume the process is restarted not to try to redo the analysis (it looks like useless) but to fix possible issue with the deleted/modified instructions. Could you try to use for (Instruction &I : make_early_inc_range(BB)) instead and avoid outer loop?
>
> Yeah that may be the issue, but I am getting test failures with it. Could it be that we need to revisit already vectorized instructions?

That's possible, if we emit extractelements. Could you try to do it in reverse order, something like make_early_inc_range(reverse(BB))?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149712/new/

https://reviews.llvm.org/D149712