[PATCH] D149712: [SLP][NFC] Cleanup: Add while loop around for loop instead of modifying iterators.

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 11:47:09 PDT 2023


vporpo added a comment.

> I assume the process is restarted not to try to redo the analysis (it looks like useless) but to fix possible issue with the deleted/modified instructions. Could you try to use for (Instruction &I : make_early_inc_range(BB)) instead and avoid outer loop?

Yeah that may be the issue, but I am getting test failures with it. Could it be that we need to revisit already vectorized instructions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149712/new/

https://reviews.llvm.org/D149712



More information about the llvm-commits mailing list