[PATCH] D149707: [Demangle] remove unused status param of itaniumDemangle

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 10:39:40 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Demangle/Demangle.h:31
 
-char *itaniumDemangle(const char *mangled_name, int *status);
+/// Returns non-null if successful a pointer to a NUL-terminated C style string
+/// that should be explicitly freed.
----------------
Place `non-null` and `a pointer to a NUL-terminated C style string` together? I.e. move `if successful` before or after them.

Also explain when the return value may be a null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149707/new/

https://reviews.llvm.org/D149707



More information about the llvm-commits mailing list