[PATCH] D149707: [Demangle] remove unused status param of itaniumDemangle

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

I think the signature `llvm::itaniumDemangle` was to match `__cxxabiv1::__cxa_demangle`: https://itanium-cxx-abi.github.io/cxx-abi/abi.html#demangler

I agree that the `status` parameter is unneeded by most users. The error categories distinguished by `status` become unuseful after the `buf` and `n` parameters were removed.

This change looks good. I am unfamiliar with how LLVMDemangle code is copied to libcxxabi. Does this change affect `libcxxabi/src/cxa_demangle.cpp`? If no, I think the patch is good to go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149707/new/

https://reviews.llvm.org/D149707