[PATCH] D149568: [AMDGPU][NFC] Preserve PDTWrapperPass in UnifyDivergentExitNodes

Wed May 3 00:31:22 PDT 2023

foad added a comment.

In D149568#4312879 <https://reviews.llvm.org/D149568#4312879>, @gandhi21299 wrote:

> In D149568#4311882 <https://reviews.llvm.org/D149568#4311882>, @foad wrote:
>
>> Should probably fix the other FIXME from 7c8b8063b66c7b936d41a0c4069c506669e13115 <https://reviews.llvm.org/rG7c8b8063b66c7b936d41a0c4069c506669e13115> at the same time.
>
> Assertion at llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp:290 fails: "SimplifyCFG is not yet capable of maintaining validity of a " "PostDomTree, so don't ask for it."

So we're using SimplifyCFG which is not capable of preserving PDT, but somehow we get lucky and don't actually hit any cases where SimplifyCFG invalidates the PDT?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149568/new/

https://reviews.llvm.org/D149568