[PATCH] D149675: [Demangle] convert itaniumDemangle and nonMicrosoftDemangle to use std::string_view

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> Is c_str2 NUL-terminated? Good question. It depends on whether c_str was NUL-terminated. When s in the above example is a std::string, then it doesn't matter whether c_str is NUL-terminated or not, c_str2 ALWAYS will be.

I am still confused... Is the bug in lld/wasm or llvm/lib/Demangle?

If the former it seems that we need a patch fixing just that part. Changing the signature of `llvm::itaniumDemangle` is useful but can be a separate patch.

If the latter, which `const char *` variable points a non-NUL-terminated string that leads to the lld/test/wasm failure?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149675/new/

https://reviews.llvm.org/D149675