[PATCH] D149675: [Demangle] convert itaniumDemangle and nonMicrosoftDemangle to use std::string_view

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 15:42:59 PDT 2023


nickdesaulniers added inline comments.


================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:94
+    Undecorated =
+        itaniumDemangle(DecoratedStr.substr(6), nullptr, nullptr, nullptr);
   }
----------------
Oh, look, another interface where `nullptr` is passed excessively by EVERY call site. Smells like another cleanup similar to D148940. Will do so in a follow up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149675/new/

https://reviews.llvm.org/D149675



More information about the llvm-commits mailing list