[PATCH] D149682: [SelectionDAG][NFCI] Use common logic for identifying MMI vars

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

This looks like a nice simplification!



================
Comment at: llvm/include/llvm/CodeGen/FunctionLoweringInfo.h:192
+  // Collection of dbg.declare instructions handled after argument
+  // lowering and before ISel proper.
+  SmallPtrSet<const DbgDeclareInst *, 4> PreprocessedDbgDeclares;
----------------
`///`


================
Comment at: llvm/include/llvm/CodeGen/FunctionLoweringInfo.h:193
+  // lowering and before ISel proper.
+  SmallPtrSet<const DbgDeclareInst *, 4> PreprocessedDbgDeclares;
+
----------------
4 seems like a low number. You could hack up a version of clang to dump the number of elements at the end and then pick something close to the median. Or you could pick 8 :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149682/new/

https://reviews.llvm.org/D149682