[PATCH] D149682: [SelectionDAG][NFCI] Use common logic for identifying MMI vars

Felipe de Azevedo Piovezan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 12:58:13 PDT 2023


fdeazeve added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6174
-    }
-
     SDValue &N = NodeMap[Address];
----------------
In case you're curious, all of this code is duplicated in the next file (SelectionDAGISel.cpp). You can see it in this review.

Note how the FastIsel branch had a very different logic (see the previous file in this review), even though it also calls this deleted code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149682/new/

https://reviews.llvm.org/D149682



More information about the llvm-commits mailing list